[Bug 733235] decodebin:Handle the multi-queue size flexible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733235

--- Comment #39 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309046:
 --> (https://bugzilla.gnome.org/review?bug=733235&attachment=309046)

Some more things, I'm fixing them up now and merge everything.

::: gst/playback/gstdecodebin2.c
@@ +1102,3 @@
   decode_bin->connection_speed = DEFAULT_CONNECTION_SPEED;
+
+  decode_bin->extra_buffer_required = FALSE;

This also needs to be reset to FALSE whenever decodebin goes back to READY

@@ +3559,3 @@
+  GST_DEBUG_OBJECT (multiqueue,
+      "use buffering %d, add extra buffer size mode %d", use_buffering,
+      dbin->extra_buffer_required);

Why not have this here:
gint extra_bytes = (dbin->extra_buffer_required ?
DEFAULT_EXTRA_SIZE_BUFFERS_BYTES : 0);
gint extra_buffers = ...;

and then just add those values below instead of adding a new if-case?

@@ +3577,3 @@
+  } else if (dbin->extra_buffer_required) {
+    max_bytes = AUTO_PREROLL_SIZE_BYTES + DEFAULT_EXTRA_SIZE_BUFFERS_BYTES;
+    max_buffers = AUTO_PREROLL_SIZE_BUFFERS +
DEFAULT_EXTRA_SIZE_BUFFERS_BYTES;

You're adding buffers and bytes here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.