[Bug 753781] tags: Add support for ImageNumber / ImageID EXIF tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753781

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309509|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309509:
 --> (https://bugzilla.gnome.org/review?bug=753781&attachment=309509)

See comments above also

::: gst/gsttaglist.h
@@ +652,3 @@
+ * Number assigned to an image, e.g., in a chained image burst. (long)
+ */
+#define GST_TAG_IMAGE_NUMBER           "image-number"

You register the tag with UINT, and define it here as long. Which one should it
be? :)

long is generally a bad idea, make it either uint or uint64

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.