[Bug 753779] tags: Add support for CinemaDNG EXIF tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753779

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309507|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309507:
 --> (https://bugzilla.gnome.org/review?bug=753779&attachment=309507)

Please attach as a "git format-patch" style patch with a descriptive commit
message

::: gst-libs/gst/tag/tag.h
@@ +352,3 @@
+ * GST_TAG_TIMECODES:
+ *
+ * Array of 8-byte timecode structures defined in SMPTE 331M-2004, Section 8.3

8 byte or 8 bit? The exif handling seems to use one byte

@@ +358,3 @@
+ * GST_TAG_FRAME_RATE:
+ *
+ * Fraction describing the frame rate of the video.

The docs usually have the exact type of the tag in parenthesis at the end

::: gst-libs/gst/tag/tags.c
@@ +200,3 @@

+  gst_tag_register_static (GST_TAG_TIMECODES, GST_TAG_FLAG_META,
+      G_TYPE_BYTE_ARRAY, _("timecodes"), _("Array of timecodes (up to 10, "

This should probably be a GstBuffer or GBytes

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.