[Bug 753769] srtpenc: add utility for custom RTP packet management before being protected

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Aug 19 01:24:14 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753769

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309486:
 --> (https://bugzilla.gnome.org/review?bug=753769&attachment=309486)

::: ext/srtp/gstsrtpenc.c
@@ +408,3 @@
+      G_STRUCT_OFFSET (GstSrtpEncClass, add_rtp_handler), NULL, NULL,
+      gst_srtp_marshal_VOID__OBJECT_STRING, G_TYPE_NONE, 2,
+      GST_TYPE_BASE_RTP_HANDLER, G_TYPE_STRING);

What about removing handlers again? This doesn't look very nice API to me in
general, signals would be preferred here as they solve exactly the same
problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list