[Bug 753769] srtpenc: add utility for custom RTP packet management before being protected

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753769

--- Comment #10 from Miguel París Díaz <mparisdiaz at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> Review of attachment 309486 [details] [review]:
> 
> ::: ext/srtp/gstsrtpenc.c
> @@ +408,3 @@
> +      G_STRUCT_OFFSET (GstSrtpEncClass, add_rtp_handler), NULL, NULL,
> +      gst_srtp_marshal_VOID__OBJECT_STRING, G_TYPE_NONE, 2,
> +      GST_TYPE_BASE_RTP_HANDLER, G_TYPE_STRING);
> 
> What about removing handlers again? This doesn't look very nice API to me in
> general, signals would be preferred here as they solve exactly the same
> problem.

I also prefer signals as I said before, but it is significantly more
inefficient, isn't it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.