[Bug 753806] [REGRESSION] aggregator: Default to "zero" start time selection mode as documented broke several GES Validate tests
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Aug 19 04:10:22 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=753806
--- Comment #1 from Thibault Saunier <tsaunier at gnome.org> ---
A simple patch like:
diff --git a/gst-libs/gst/base/gstaggregator.c
b/gst-libs/gst/base/gstaggregator.c
index a0a8776..781efdb 100644
--- a/gst-libs/gst/base/gstaggregator.c
+++ b/gst-libs/gst/base/gstaggregator.c
@@ -2157,7 +2157,7 @@ gst_aggregator_pad_chain_internal (GstAggregator * self,
switch (self->priv->start_time_selection) {
case GST_AGGREGATOR_START_TIME_SELECTION_ZERO:
default:
- start_time = 0;
+ start_time = -1;
break;
case GST_AGGREGATOR_START_TIME_SELECTION_FIRST:
if (aggpad->segment.format == GST_FORMAT_TIME) {
fixes the issue as it avoid getting into the "if (start_time != -1) {" branch
and thus avoids any change in behaviour. But that might not be correct.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list