[Bug 753822] assrender: do not crash when video frame mapping fails

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Aug 19 06:36:15 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753822

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309577|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309577:
 --> (https://bugzilla.gnome.org/review?bug=753822&attachment=309577)

::: ext/assrender/gstassrender.c
@@ +1238,2 @@
       } else {
         GST_DEBUG_OBJECT (render, "nothing to render right now");

Here you should probably set render->composition to NULL. In the old code, if
this case was reached no overlaying was happening. In your code, you would
render whatever render->composition contains currently.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list