[Bug 753907] asfdemux: skip a frame with an abnormal time stamp.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753907

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309786|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309786:
 --> (https://bugzilla.gnome.org/review?bug=753907&attachment=309786)

Please provide a "git format-patch" style patch :)

::: gst/asfdemux/gstasfdemux.c
@@ +1742,3 @@
+            GST_TIME_ARGS (GST_BUFFER_PTS (payload->buf)),
+            GST_TIME_ARGS (demux->segment.duration));
+        gst_buffer_unref (payload->buf);

It might be a good idea to explicitly set ret = GST_FLOW_OK here. Also there
might be cases where the duration is reported wrong, and there are actually
valid buffers after the reported duration. This might break such streams.

@@ +1744,3 @@
+        gst_buffer_unref (payload->buf);
+      } else
+        ret = gst_pad_push (stream->pad, payload->buf);

Add some {} around here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.