[Bug 752230] mpdparser: Parse xlink attributes from Period, AdaptationSet and SegmentList

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 21 08:36:01 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=752230

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #11)
> (In reply to Thiago Sousa Santos from comment #9)
> > Review of attachment 309818 [details] [review] [review]:
> > 
> > ::: ext/dash/gstmpdparser.c
> > @@ +3540,3 @@
> > +      client->mpd_node->Periods =
> > +          g_list_insert_before (client->mpd_node->Periods, tmp, l->data);
> > +    g_list_free (new_periods);
> > 
> > My main concern here is about how the timing of period start will be
> > affected. And also about what happens with seeking across periods?

That's solveable, I have a plan that has minimal impact on the code ;) With the
current patch there is no problem though, they are loaded before start/etc are
calculated.

> Would there be a chance that a stream's period_idx variable would go
> inconsistent because of those period add/removal?

Not with the current patch, the later patches (to be done) will make sure they
don't become inconsistent.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list