[Bug 754024] HEVC Codecparser fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754024

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309915|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309915:
 --> (https://bugzilla.gnome.org/review?bug=754024&attachment=309915)

Seems ok to me (without having the spec) but

::: gst-libs/gst/codecparsers/gsth265parser.c
@@ +1805,3 @@
+      ceil ((gdouble) sps->pic_height_in_luma_samples / (gdouble) CtbSizeY);
+  pps->PicWidthInCtbsY =
+      ceil ((gdouble) sps->pic_width_in_luma_samples / (gdouble) CtbSizeY);

Can we have integer arithmetic here? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.