[Bug 754024] HEVC Codecparser fixes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 25 13:21:17 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=754024

--- Comment #7 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> Review of attachment 309915 [details] [review]:
> 
> Seems ok to me (without having the spec) but
> 
> ::: gst-libs/gst/codecparsers/gsth265parser.c
> @@ +1805,3 @@
> +      ceil ((gdouble) sps->pic_height_in_luma_samples / (gdouble) CtbSizeY);
> +  pps->PicWidthInCtbsY =
> +      ceil ((gdouble) sps->pic_width_in_luma_samples / (gdouble) CtbSizeY);
> 
> Can we have integer arithmetic here? :)


As per spec "% Used to denote division in mathematical equations where no
truncation or rounding is intended."
and PicWidthInCtbsY= Ceil (sps->pic_width_in_luma_samples % CtbSizeY)

Do you want to get a custom ceil function to get this job done with integer
arithmetic??

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list