[Bug 754178] gst-discoverer doesn't detect both audio and video of RTSP streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754178

--- Comment #4 from Vineeth <vineeth.tm at samsung.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 310151 [details] [review]:
> 
> I think the merging should better take place inside uridecodebin
> 
I am guessing that topology is used only in case of discover? If that is the
case i felt, it is not that important to make the changes in uridecodebin..
But yeah that will help in consistency..


> ::: gst-libs/gst/pbutils/gstdiscoverer.c
> @@ +1233,3 @@
>  
> +    if (dc->priv->current_topology) {
> +      if (g_list_length (dc->priv->current_topology) > 1) {
> 
> > 1? Not > 0? You need to merge once there already is one topology and a new one arrives, no?
> 
> @@ +1238,3 @@
> +            g_object_new (GST_TYPE_DISCOVERER_CONTAINER_INFO, NULL);
> +
> +        dc->priv->current_info->stream_info = (GstDiscovererStreamInfo *)
> cont;
> 
> Now if another topology arrives afterwards, you would add this container
> here and the new topology into yet another container. I think it would be
> better to merge them into the same container instead.

In ideal cases, discoverer_collect will be called after all the topologies are
received. The reason i am checking for >1 is, a new container should be created
only if there are more than one topology.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.