[Bug 754212] cutter: Fix buffer leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754212

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310152|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 310152:
 --> (https://bugzilla.gnome.org/review?bug=754212&attachment=310152)

::: gst/cutter/gstcutter.c
@@ +253,3 @@
+    {
+      GstBuffer *prebuf;
+      while (filter->pre_buffer) {

Why not just g_list_free_full(filter->pre_buffer, (GFunc) gst_buffer_unref,
NULL)? :)


And I don't know what this element is doing or if it works at all, so please
check if it makes sense to also free those buffers on caps changes or flushing
;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.