[Bug 753806] [REGRESSION] aggregator: Default to "zero" start time selection mode as documented broke several GES Validate tests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753806

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Olivier Crête from comment #7)
> 
> I still think the code is fishy, why does it do a MIN() on the various
> values, since it will not happen after a seek, only right after a
> gst_segment_init() where start, time and position are 0.

You're talking about line 2196-8? That's for the FIRST mode. We will wait there
for the first buffer, and will chose the smallest timestamp of all incoming
streams. Not the first buffer that happens to arrive on any stream, but the
smallest timestamp that arrives first on all streams.

For all other cases the MIN is useless and shouldn't have any effect at all.
Your patch seems correct though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.