[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #69 from Lubosz Sarnecki <lubosz at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #63)
> (In reply to Matthew Waters from comment #55)
> > Review of attachment 316108 [details] [review] [review]:
> > 
> > Some comments
> > 
> > ::: gst-libs/gst/gl/gstglupload.c
> > @@ +524,3 @@
> > +GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE_WITH_FEATURES
> > +    ("memory:" GST_ALLOCATOR_DMABUF,
> > +        "{ ABGR, ARGB, BGRA, BGRx, RGB16, RGBA, RGBx, xBGR, xRGB }"));
> > 
> > The example pipeline in the blurb won't work with this template.  There are
> > no YUV formats here so format=NV12 is using the raw uploader which means
> > nothing has changed.
> 
> In fact, it's using it, though not with memory:DMABuf caps feature. How to
> use that new caps feature isn't well defined, and is not essential for
> libgstgl (because we have fallbacks for everything). So let's remove that
> for now, George is also working on improving how we will use that caps
> feature, we can then implement seperatly and consistently.
> 

These caps are not necessary when using the uploader with v4l2src, since it
does not support the memory:dmabuf caps feature.
The dmabuf uploader accepts the upload when gst_is_dmabuf_memory is true.

The code is mandatory to accept dmabuf caps with gkiagia's inteldmabufupload
element, and in the future with v4l2src, when it will support this caps feature
in the correct io-mode. gkiagia is currently working on a drmdmabufupload
element which will surely also support this caps feature.

The formats above are the ones working with inteldmabufupload, but they can in
theory be expanded to the capabilities of glconvert.
I can remove the caps features part, since there is currently no upstream
element supporting them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.