[Bug 743345] glupload: Add support for dmabuf

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Dec 1 06:36:03 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743345

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316601|none                        |needs-work
             status|                            |

--- Comment #73 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 316601:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316601)

::: gst-libs/gst/gl/gstglupload.c
@@ +561,3 @@
+    ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_GL_MEMORY);
+  } else {
+    ret = _set_caps_features (caps, "memory:" GST_ALLOCATOR_DMABUF);

This is still wrong. We need a proper define and documentation for that caps
feature before introducing it. In V4L2src, you will never require that caps
feature, we will produce dmabuf regardless in the near future.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list