[Bug 758754] oggdemux: failing to play an Opus sample file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758754

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316445|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316445:
 --> (https://bugzilla.gnome.org/review?bug=758754&attachment=316445)

::: gst-libs/gst/pbutils/codec-utils.c
@@ +1535,3 @@
+  version = gst_byte_reader_get_uint8_unchecked (&br);
+  if (version != 0x01) {
+    GST_DEBUG ("Opus Header version is wrong, should be 0x01 and not %d",

Make this a GST_ERROR() and accept only 0x00 and 0x01 at this point. If 0x02 or
higher is found, reject it :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.