[Bug 758515] dashdemux : suggestion for setting the framerate info at dashdemux.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758515

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316132|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316132:
 --> (https://bugzilla.gnome.org/review?bug=758515&attachment=316132)

::: ext/dash/gstdashdemux.c
@@ +886,3 @@
     gst_caps_set_simple (caps, "width", G_TYPE_INT, width, "height",
+        G_TYPE_INT, height, "framerate", GST_TYPE_FRACTION, fps_num,
+        fps_den, NULL);

I think it makes sense to a) set the framerate also if width==0 || height == 0
and b) to only set the framerate if we actually know it
(get_video_stream_framerate() returns a boolean).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.