[Bug 755260] decodebin: Fix a race condition accessing the decode_chain field.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Dec 1 09:42:09 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755260

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.7.1

--- Comment #5 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
I pushed this patch along the ones from
https://bugzilla.gnome.org/show_bug.cgi?id=752651

The test case from the other bug works for quite a while (though not 100%) with
all those patches. Any further fix can be merged later if necessary.

Thanks

commit 2c62aad159694b0f4fb1d19297abc4c38650bcb9
Author: Thomas Bluemel <tbluemel at control4.com>
Date:   Fri Nov 6 14:21:14 2015 +0000

    [PATCH] Fix a race condition accessing the decode_chain field.

    Make sure that any access to the GstDecodeBin's decode_chain
    field is protected using the EXPOSE_LOCK.  Also add a simple
    reference counter to the GstDecodeChain structure so that when
    the type_found signal fires it can hold onto the decode chain
    even while the EXPOSE_LOCK is not held.  This should fix a
    race condition if the type_found signal fires right in the
    middle of a state change that messes with the same decode
    chain.

    https://bugzilla.gnome.org/show_bug.cgi?id=755260

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list