[Bug 758515] dashdemux : suggestion for setting the framerate info at dashdemux.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758515

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316635|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316635:
 --> (https://bugzilla.gnome.org/review?bug=758515&attachment=316635)

::: ext/dash/gstdashdemux.c
@@ +878,3 @@
     width = gst_mpd_client_get_video_stream_width (stream);
     height = gst_mpd_client_get_video_stream_height (stream);
+    fps_ret =

I would call this have_fps but this also works :)

@@ +888,3 @@
     gst_caps_set_simple (caps, "width", G_TYPE_INT, width, "height",
+        G_TYPE_INT, height, "framerate", GST_TYPE_FRACTION, fps_num,
+        fps_den, NULL);

Here you always set a framerate if width/height exists.

@@ +892,3 @@
+    if (fps_ret) {
+      gst_caps_set_simple (caps, "framerate", GST_TYPE_FRACTION, fps_num,
+          fps_den, NULL);

Just move all this out of the if.

if (width > 0 && height > 0) {
  set width and height
}

if (fps_ret) {
  set framerate
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.