[Bug 758877] glupload: Should not offer its allocator unless memory:GLMemory is negotiated

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 2 15:46:55 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=758877

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316630|none                        |reviewed
             status|                            |

--- Comment #11 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316630:
 --> (https://bugzilla.gnome.org/review?bug=758877&attachment=316630)

Looks ok to me.

There's a typo in one the comments.

::: gst-libs/gst/gl/gstglupload.c
@@ +439,1 @@
+  /* Only offer out custom allocator if that type of memory was negotiated. */

s/out/our/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list