[Bug 758515] dashdemux : suggestion for setting the framerate info at dashdemux.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758515

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Suhwang Kim from comment #12)
> I know your last two comments.
> 
> 1) if (stream->cur_adapt_set && stream-cur_adapt_set->maxFrameRate != NULL)
> I think "stream->cur_adapt_set &&" does not need. Because of
> "stream->cur_adapt_set" already check the as below.
> +  if (stream == NULL || stream->cur_adapt_set == NULL
> +      || stream->cur_representation == NULL)
> +    return FALSE;

That's exactly my point :) Remove the additional check at the top and add the
relevant checks to each if. That way it's easier to extend the code later.

> 2) I already check your comment.
> Please See your gstmpdparser.h.
> [...]

What I mean is that you should use the frameRate field if available, and only
otherwise use maxFrameRate. Currently the code does it the other way around.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.