[Bug 745372] vpxdec: Should try to avoid copies at output

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745372

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316631|accepted-commit_now         |needs-work
             status|                            |

--- Comment #19 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Comment on attachment 316631
  --> https://bugzilla.gnome.org/attachment.cgi?id=316631
vpxdec: Use GstMemory to avoid copies

Ok, found a slight issue. When I append the memory, the buffer will try to get
an exclusive reference (_memory_get_exclusive_reference()). That means it will
GST_LOCK_FLAG_EXCLUSIVE and gst_memory_ref(). Though, the buffer is already
write locked, which prevent the exclusive lock, so the gst_buffer_append() call
will copy the memory. So we effectively endup with the same performance.

That means for this use case, I strictly need to be able to downgrade to a read
lock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.