[Bug 758183] gst-libav-1.6 broke compatibility with libav

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758183

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316738|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316738:
 --> (https://bugzilla.gnome.org/review?bug=758183&attachment=316738)

In general looks good, just some minor comments :) Also please squash together
with the other patch

::: ext/libav/gstav.c
@@ +51,3 @@
+
+  /* FFmpeg *_MICRO versions start at 100 and Libav's at 0 */
+  if ((av_version & 0xff) < 100)

Doesn't it have macros to extract major/minor/micro from the version integer?

@@ +142,3 @@

+  /* Bail if not FFmpeg. We can no longer ensure operation with Libav */
+  if (!gst_ffmpeg_avcodec_is_ffmpeg ()) {

Do that as the very first thing in plugin_init() before e.g. setting the log
callback

-- 
You are receiving this mail because:
You are the QA Contact for the bug.