[Bug 758515] dashdemux : suggestion for setting the framerate info at dashdemux.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Dec 4 04:12:07 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=758515
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #316744|none |needs-work
status| |
--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316744:
--> (https://bugzilla.gnome.org/review?bug=758515&attachment=316744)
::: ext/dash/gstmpdparser.c
@@ +5659,3 @@
+ if (stream->cur_adapt_set && stream->cur_adapt_set->maxFrameRate != NULL) {
+ *fps_num = stream->cur_adapt_set->maxFrameRate->num;
+ *fps_den = stream->cur_adapt_set->maxFrameRate->den;
maxFrameRate should probably be in RepresentationBase. According to the spec it
can also be in Representation and SubRepresentation, not only in AdaptationSet.
Can you provide a second patch to the parser to change this accordingly?
Apart from that this patch looks ok now
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list