[Bug 758234] baseparse regression causes performance problem on embedded systems

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758234

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315996|none                        |needs-work
             status|                            |

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315996:
 --> (https://bugzilla.gnome.org/review?bug=758234&attachment=315996)

I general makes sense IMHO.

::: libs/gst/base/gstbaseparse.c
@@ +1695,3 @@
 {
+  /* Only update the tag on a 2% change */
+  static const gfloat update_threshold = 2.0;

We usually use #defines for this kind of stuff

@@ +1760,3 @@
+    if (parse->priv->post_avg_bitrate && parse->priv->avg_bitrate) {
+      gfloat diffprev = (float) 100.0 * (ABSDIFF (parse->priv->avg_bitrate,
+          parse->priv->posted_avg_bitrate)) / (float)
parse->priv->avg_bitrate;

Would be nicer to do this without floating point operations, which is easily
possible here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.