[Bug 759089] New: Add a fallback that copies the commit hook in autogen.sh

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Dec 6 07:14:42 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=759089

            Bug ID: 759089
           Summary: Add a fallback that copies the commit hook in
                    autogen.sh
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: francisv at mail.uio.no
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The code below in autogen.sh of gstreamer modules fails when for some reason
symbolic links cannot be created. For example, when setting up an
uninstalled-setup in a mounted Ubuntu partition in a VM of VirtualBox.

# install pre-commit hook for doing clean commits
if test ! \( -x .git/hooks/pre-commit -a -L .git/hooks/pre-commit \);
then
    rm -f .git/hooks/pre-commit
    ln -s ../../common/hooks/pre-commit.hook .git/hooks/pre-commit
fi

Edited comments from IRC:

- The symbolic link is relevant for making patches. It will run the code
through gst-indent to check the style/indentation when you run git commit.

- Proposed solution: add a fallback that copies the commit hook (explains why
Windows dev always get the indent wrong)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list