[Bug 758980] filesrc/others: Add support for files larger than 2GB on Android and other platforms without _FILE_OFFSET_BITS=64 support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758980

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Reynaldo H. Verdejo Pinochet from comment #10)
> (In reply to Sebastian Dröge (slomo) from comment #8)
> > Comment on attachment 316919 [details] [review] [review]
> > filesrc: enable largefile support on Android
> > 
> > Same here, same problem with fstat() vs fstat64().
> 
> Bionic (checked android-9) has fstat64 as an alias to fstat
> and the implementation seems to be 64bits-aware as far as I
> saw. ftruncate we will have to implement though. Thanks
> for taking a look

Indeed, but let's better be explicit about that and use fstat64() on bionic in
case they ever change that :)

(In reply to Reynaldo H. Verdejo Pinochet from comment #11)
> (In reply to Reynaldo H. Verdejo Pinochet from comment #10)
> > (In reply to Sebastian Dröge (slomo) from comment #8)
> > > Comment on attachment 316919 [details] [review] [review] [review]
> > > filesrc: enable largefile support on Android
> > > 
> > > Same here, same problem with fstat() vs fstat64().
> > 
> > Bionic (checked android-9) has fstat64 as an alias to fstat
> > and the implementation seems to be 64bits-aware as far as I
> > saw. ftruncate we will have to implement though. Thanks
> > for taking a look
> 
> And, thinking abut this twice, the only call to ftruncate()
> we have on the code does ftruncate(,0) which should work
> with BIONIC's ftruncate regardless or is there something I'm
> missing?

Most likely you're right, unless there is something silly internally. Let's
keep it like that for now I guess

-- 
You are receiving this mail because:
You are the QA Contact for the bug.