[Bug 743905] multiqueue: handle the BUFFERING query

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 10 06:23:05 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743905

--- Comment #7 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 295990:
 --> (https://bugzilla.gnome.org/review?bug=743905&attachment=295990)

::: plugins/elements/gstmultiqueue.c
@@ +1985,3 @@
+
+        update_buffering (mq, sq);
+        gst_query_set_buffering_percent (query, mq->buffering, mq->percent);

You're returning the overall buffering percent and not the specific pad
buffering level. Is this intentional?

If you query on the video sink you can get the video level, if you query on the
audio sink you could want the audio level.

playbin could be responsible for aggregating the results from multiple sinks if
the query was sent to the pipeline. It would be tricky to aggregate
input/output rates and buffering ranges, though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list