[Bug 759329] convertframe: Support video crop when convert frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759329

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317186|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317186:
 --> (https://bugzilla.gnome.org/review?bug=759329&attachment=317186)

In theory videoscale and videoconvert could also do the cropping nowadays.
GstVideoConverter has support for it. But making them do here if both
converters don't have to convert everything might not be easy, needs to be
checked

::: gst-libs/gst/video/convertframe.c
@@ +121,3 @@
   GST_DEBUG ("creating elements");
   if (!create_element ("appsrc", &src, &error) ||
+      !create_element ("videocrop", &vcrop, &error) ||

videocrop is in gst-plugins-good, so the usage of it here should be optional

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.