[Bug 726314] Add cookie jar to uridownloader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=726314

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314302|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 314302:
 --> (https://bugzilla.gnome.org/review?bug=726314&attachment=314302)

I think the approach is good, just one comment here (and we need to make sure
the GstContext machinery works here properly)

::: ext/soup/gstsouphttpsrc.c
@@ +2039,3 @@
+          cookies[0] = cookie;
+          cookies[1] = NULL;
+          gst_structure_set (context_structure, "cookies", G_TYPE_STRV,
cookies,

Is this really enough? Isn't a cookie usually stored together with the domain
and where it can be used, to prevent arbitrary websites reading your cookies
from elsewhere?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.