[Bug 759329] convertframe: Support video crop when convert frame
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Dec 11 01:19:20 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=759329
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #317188|none |needs-work
status| |
--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317188:
--> (https://bugzilla.gnome.org/review?bug=759329&attachment=317188)
::: gst-libs/gst/video/convertframe.c
@@ +119,3 @@
+ if (!create_element ("videocrop", &vcrop, &error))
+ GST_DEBUG ("No videocrop element, can't process crop.");
Not a problem if no crop meta but see below
@@ +140,3 @@
+ gst_bin_add_many (GST_BIN (pipeline), src, vcrop, csp, vscale, sink,
NULL);
+ else
+ gst_bin_add_many (GST_BIN (pipeline), src, csp, vscale, sink, NULL);
Maybe keep the old add_many() line and then only add a
if (vcrop) gst_bin_add (GST_BIN (pipeline), vcrop)
@@ +152,3 @@
+ GST_DEBUG ("crop meta [x,y,width,height]: %d %d %d %d", cmeta->x,
+ cmeta->y, cmeta->width, cmeta->height);
+ }
if (!vcrop && cmeta) this should probably print a g_warning()
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list