[Bug 759329] convertframe: Support video crop when convert frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759329

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317191|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317191:
 --> (https://bugzilla.gnome.org/review?bug=759329&attachment=317191)

::: gst-libs/gst/video/convertframe.c
@@ +122,3 @@
+    if (cmeta)
+      g_warning ("buffer has crop meta, but no videocrop element. ");
+      g_warning ("can't process crop.");

Put this in a single g_warning() and prefix it with where this comes from, e.g.

g_warning("gst_video_convert_sample: Buffer has crop metadata but videocrop
element is not found. Cropping will be disabled")

@@ +142,3 @@
   GST_DEBUG ("adding elements");
   gst_bin_add_many (GST_BIN (pipeline), src, csp, vscale, sink, NULL);
+  if (vcrop) gst_bin_add (GST_BIN (pipeline), vcrop);

You should also run gst-indent on your .c files before you submit patches :) A
line break is missing here

@@ +163,3 @@
+      goto link_failed;
+
+    GST_DEBUG ("linking vcrop->csp");

It might be necessary to have another videoconvert before videocrop too

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.