[Bug 756082] qmlglsink: add a QML extension plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756082

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317314:
 --> (https://bugzilla.gnome.org/review?bug=756082&attachment=317314)

::: ext/qt/Makefile.am
@@ +88,3 @@
+
+libglvideoitemplugin_la_LDFLAGS =  -module -avoid-version
+libglvideoitemplugin_la_LIBTOOLFLAGS = --tag=disable-static

So on Android and iOS Qt is using shared libraries as plugins?

::: ext/qt/glvideoitemplugin.cc
@@ +31,3 @@
+{
+  Q_ASSERT(uri == QLatin1String("org.freedesktop.gstreamer.GLVideoItem"));
+  qmlRegisterType<QtGLVideoItem> (uri, 1, 0, "GstGLVideoItem");

The easiest on those platforms would probably be to statically link the
GStreamer plugin into the Qt plugin shared library, and then initialize the
GStreamer plugin from here. However that would then work different as with the
other GStreamer plugins on those platforms.

The alternative would be that the application still needs to initialize the
GStreamer plugin before being able to use the QML plugin, which our build
system stuff for these platforms is automatically doing. If you use that.
That's what your changes now are doing AFAIU.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.