[Bug 759520] pnmenc: Fix memory leaks/mishandling

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 16 00:56:54 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=759520

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317467|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317467:
 --> (https://bugzilla.gnome.org/review?bug=759520&attachment=317467)

::: gst/pnm/gstpnmenc.c
@@ +203,3 @@
   if (pnmenc->info.encoding == GST_PNM_ENCODING_ASCII) {
     /* Per component 4 bytes are used in case of ASCII encoding */
+    size = size * (4 + 1 / 20);

This does not seem correct. 1/20 is always 0, so this is always size*4.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list