[Bug 759484] directsoundsrc: add device property as it is done in directsoundsink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759484

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317507|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317507:
 --> (https://bugzilla.gnome.org/review?bug=759484&attachment=317507)

::: sys/directsound/gstdirectsoundsrc.c
@@ +429,3 @@
+    /* Create capture object */
+    hRes =
+        pDSoundCaptureCreate (dsoundsrc->device_guid, &dsoundsrc->pDSC, NULL);

You have this line twice here now

@@ +437,3 @@
+  // mixer is only supported when device-id is not set
+  if (!dsoundsrc->device_id) {
+    gst_directsound_src_mixer_init (dsoundsrc);

Or maybe we should just remove the mixer support completely here?

::: sys/directsound/gstdirectsoundsrc.h
@@ +65,3 @@
 #define GST_IS_DIRECTSOUND_SRC(obj)
(G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_DIRECTSOUND_SRC))
 #define GST_IS_DIRECTSOUND_SRC_CLASS(klass)
(G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_DIRECTSOUND_SRC))
+typedef struct _GstDirectSoundSrc GstDirectSoundSrc;

Don't run gst-indent on headers, only on .c files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.