[Bug 758516] mpegtsbase: Add condition to check for non working negative rate

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Dec 22 00:55:36 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=758516

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316066|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316066:
 --> (https://bugzilla.gnome.org/review?bug=758516&attachment=316066)

::: gst/mpegtsdemux/mpegtsbase.c
@@ +1373,3 @@
     return FALSE;

+  if (rate <= 0.0) {

This will break reverse playback with HLS for example. A few lines below, for
push mode the seek event is forwarded upstream first. The check for negative
rates should only happen when not an upstream element but this code here is
handling the seek.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list