[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758384

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |thiagossantos at gmail.com
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.7.1

--- Comment #35 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
One minor thing is the check for state change from playing to paused being a
bit mysterious on the seek handling but it works. Perhaps adding a comment
would make it clear that it is one of the signals the seek event was fully
handled? Any other ideas on how to improve that part and make it a bit more
clear? Anyway it doesn't justify holding these patches in bugzilla for longer.
Thanks for the changes.

Forgot to ensure the bug url on the bottom commits, but here they are:

commit ebf6de33d2744fd68f6273e6f66dce94b8c3f552
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Tue Nov 10 16:25:53 2015 +0000

    hlsdemux: tests: check URL joining if media URL contains a '/' character

    If the query parameter (for example
    http://example.net/1054559_1500k.mp4/master.m3u8?acl=/*1054559_1500k.mp4),
    check that m3u8.c correctly converts the relative URLs of the media
    playlists in to absolute URLs. It must not use the last '/' it finds in
    the URL, as according to RFC3986 the '/' character is allowed in
    the query part of the URL.

    https://bugzilla.gnome.org/show_bug.cgi?id=758384

commit f6bff8f5f5ca14cae5774d79e7b7c4ac0542a67f
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Tue Nov 10 16:23:59 2015 +0000

    hlsdemux: unquote all the quoted-string attributes

    The URI attribute from the EXT-X-KEY tag and the URI attribute from the
    EXT-X-I-FRAMES-ONLY tag are both quoted-string attibutes that have their
    quotation marks removed during parsing. The CODECS attribute of the
    EXT-X-STREAM-INF is also a quoted-string attribute, but this attribute
    was not being un-quoted.

    This commit changes the parser to always unquote all quoted-string
    attributes and adjusts the unit tests to this new bevahiour for the
    CODECS attribute.

    An additional test is added to check that parsing of all of the fields
    in the EXT-X-STREAM tag is correct, including those that contain comma
    characters.

    https://bugzilla.gnome.org/show_bug.cgi?id=758384

commit eafdf5673a38537fc41cfdc08c29321810387a39
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Tue Nov 10 16:41:02 2015 +0000

    hlsdemux: tests: add unit tests for hlsdemux

    Using the new GstAdaptiveDemux test framework, add tests that
    exercise hlsdemux. The following tests are added:

    simpleTest
    A simple playlist that contains some media URLs

    testMediaPlaylist
    A master playlist with a variant playlist that contains media URLs

    testMediaPlaylistNotFound
    A master playlist that points to a missing variant playlist

    testFragmentNotFound
    A master playlist with a variant playlist that contains media URLs
    There is a missing media file referenced from the variant playlist.

    testFragmentDownloadError
    A master playlist with a variant playlist that contains media URLs
    During the download of one media file, the test simulates the network
    connection being dropped.

    testSeek
    A simple test of trying to perform a seek on an HLS stream.

commit ae3ed25025e34ea9b09df59d22d7ebd7294560bc
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Tue Nov 10 13:13:35 2015 +0000

    dashdemux: tests: Refactor into adaptive_engine components

    To allow code from dash_demux.c to be used by other elements
    that are based upon GstAdaptiveDemux, the code has been
    refactored into four new files:

        adaptive_demux_engine.[ch]
        adaptive_demux_common.[ch]

    The code in adaptive_demux_engine.c provides a generic
    test engine for elements based upon GstAdaptiveDemux.

    The code in adaptive_demux_common.c provides a set
    of utility functions that are common between the tests
    for hlsdemux and dashdemux.

    As part of the refactoring, variables in structures were
    renamed from using camelCase to underscore_case to match other
    GStreamer source code.

    The fake_http_src was renamed test_http_src and changed to use
    callbacks to provide input data and error conditions. Rather than
    using an array of input data that tries to encode all the
    possible use cases for the GstTestHTTPSrc element, use a struct of
    callbacks.

    Users of this element are obliged to implement at least the src_start
    callback, which provides a way to link from a URI to the settings
    for that URI.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.