[Bug 759860] glfilters: Attach composition overlay when not supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759860

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318001|none                        |needs-work
             status|                            |

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 318001:
 --> (https://bugzilla.gnome.org/review?bug=759860&attachment=318001)

I wanted to test this, and notice it breaks the build:

  CC       libgstgl_1.0_la-gstglupload.lo
gstglupload.c: In function '_dma_buf_upload_transform_caps':
gstglupload.c:622:11: error: implicit declaration of function
'_set_caps_features' [-Werror=implicit-function-declaration]
     ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_GL_MEMORY);
           ^
gstglupload.c:622:5: error: nested extern declaration of '_set_caps_features'
[-Werror=nested-externs]
     ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_GL_MEMORY);
     ^
gstglupload.c:622:9: error: assignment makes pointer from integer without a
cast [-Werror=int-conversion]
     ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_GL_MEMORY);
         ^
gstglupload.c:626:9: error: assignment makes pointer from integer without a
cast [-Werror=int-conversion]
     ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY);
         ^
gstglupload.c:636:27: error: 'passthrough' undeclared (first use in this
function)
   gst_caps_features_free (passthrough);
                           ^
gstglupload.c:636:27: note: each undeclared identifier is reported only once
for each function it appears in
cc1: all warnings being treated as errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.