[Bug 757597] Codecparsers: add vp9 parser

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757597

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317018|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 317018:
 --> (https://bugzilla.gnome.org/review?bug=757597&attachment=317018)

Just some minor things, please fix before merging

::: gst-libs/gst/codecparsers/Makefile.am
@@ +19,3 @@
     gstjpegparser.h \
+    gstmpegvideometa.h \
+    gstvp9parser.h vp9utils.h

vp9utils.h should probably be in noinst_HEADERS

::: gst-libs/gst/codecparsers/gstvp9parser.h
@@ +89,3 @@
+ * @GST_VP9_PROFILE_1: Profile 1, 8-bit 4:4:4, 4:2:2, and 4:4:0.
+ * @GST_VP9_PROFILE_2: Profile 2, 10-bit and 12-bit color only, with 4:2:0
sampling.
+ * @GST_VP9_PROFILE_3: Profile 3, 10-bit and 12-bit color only, with
4:2:2/4:4:4/4:4:0 sampling.

Would be nice to also add support for all these profiles to vp9enc/dec :) Do
you know of sample streams?

::: gst-libs/gst/codecparsers/vp9utils.h
@@ +21,3 @@
+int16_t vp9_dc_quant(int qindex, int delta, int bit_depth);
+
+int16_t vp9_ac_quant(int qindex, int delta, int bit_depth);

These 3 functions can easily cause symbol conflicts. Rename them please, add a
gst_vp9 prefix or whatever. Bonus points for adding G_GNUC_INTERNAL here (and
for vp8utils)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.