[Bug 707543] [API] add GstBitWriter

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=707543

--- Comment #22 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Some comments/questions:

- should we derive bitwriter from bitreader like we do with bytewriter?

- gst_bit_writer_new (guint32 reserved_bits) --> new_with_size (guint32
reserved_bits)

- gst_bit_writer_new_fill (guint8 * data, guint bits) -->  _new_with_data
(guint8 * data, guint bits, gboolean initialized), but the 'initialized'
parameter only makes sense if we can/want to make the writer derive from the
reader somehow (see above)

- gst_bit_writer_free (GstBitWriter * writer, gboolean free_data); -> _free
(bw); also add _reset(), _reset_and_get_data(), _reset_and_get_buffer(),
_free_and_get_data(), _free_and_get_buffer() ?

- _init() -> _init_with_size(), + plain _init()

- _init_fill() -> init_with_data();

- gst_bit_writer_clear() -> _reset*() ? (more consistent with ByteWriter, even
though we use _clear() elsewhere

- gst_bit_writer_set_pos(): gtk-doc chunk has wrong header

- gst_bit_writer_get_space() -> get_remaining() to match ByteWriter?

- gst_bit_writer_put_bits_uint8|uint16|uint32|uint64 - do we need all these
variants, vs. just _put_bits (guint bits, guint nbits) + perhaps put_bits64() ?

- gst_bit_writer_put_bytes() -> put_data() perhaps? (maybe also with guint
nbits rather than nbytes?)

I can help make the changes once we agree what it should look like.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.