[Bug 760024] jpegdec: Extra buffers and memcpy() overhead

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 31 11:05:09 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=760024

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318062|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 318062:
 --> (https://bugzilla.gnome.org/review?bug=760024&attachment=318062)

A comment that show you have researched why it was done like this before and
what you are doing to avoid the issue that the copies where fixing seems rather
important. You seem to simply use pointers directly and no code is adding any
memory management. This is in general suspicious, I didn't look in details, but
please, demonstrate that you have done some research about why it was like
this, and demonstrate that you keep proper memory management without those
copies.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list