[Bug 743795] gtask: add thread name support on OS X and iOS

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Feb 1 12:16:07 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743795
  GStreamer | gstreamer (core) | git master

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-02-01 20:16:01 UTC ---
(In reply to comment #6)
> #if UNDEFINED_MACRO triggers an error?

A warning, which is treated as error in git master.

> 
> Anyway, #if defined (_MSC_VER) is detecting the wrong thing. It's detecting
> Microsoft C++ compiler. It usually corresponds to Win32 platform, but you
> obviously understand why it's the wrong define to look at.
> 
> To be fully correct, change this to #if defined(_WIN32). Change the other
> #ifdef _MSC_VER in the file -- where SetThreadName is implemented -- to #if
> defined(_WIN32) as well.

Would it be possible to provide a patch ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list