[Bug 743871] validate: Provide a way to test failing socket operations.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743871
  GStreamer | gst-devtools | unspecified

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295960|none                        |reviewed
             status|                            |

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> 2015-02-02 17:07:37 UTC ---
Review of attachment 295960:
 --> (https://bugzilla.gnome.org/review?bug=743871&attachment=295960)

::: validate/configure.ac
@@ +64,3 @@

+dnl Tiny library overriding calls such as socket recv / send
+FAULTINJECTION_LIBS="-L$(top_srcdir)/fault_injection/.libs/
-lfaultinjection-$GST_API_VERSION"

That does not look right (ie. specifiing .libs)

::: validate/gst/validate/Makefile.am
@@ +47,3 @@
 lib_LTLIBRARIES = libgstvalidate- at GST_API_VERSION@.la
+libgstvalidate_ at GST_API_VERSION@_la_CFLAGS = $(GST_ALL_CFLAGS)\
+    $(GIO_CFLAGS) $(GST_PBUTILS_CFLAGS) -I$(top_srcdir)/fault_injection

I do not understand why you link Validate against that lib here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.