[Bug 743871] validate: Provide a way to test failing socket operations.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743871
  GStreamer | gst-devtools | unspecified

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> 2015-02-02 20:24:39 UTC ---
(In reply to comment #3)
> Review of attachment 295960 [details]:
> 
> ::: validate/configure.ac
> @@ +64,3 @@
> 
> +dnl Tiny library overriding calls such as socket recv / send
> +FAULTINJECTION_LIBS="-L$(top_srcdir)/fault_injection/.libs/
> -lfaultinjection-$GST_API_VERSION"
> 
> That does not look right (ie. specifiing .libs)

Indeed, and it's not needed

> 
> ::: validate/gst/validate/Makefile.am
> @@ +47,3 @@
>  lib_LTLIBRARIES = libgstvalidate- at GST_API_VERSION@.la
> +libgstvalidate_ at GST_API_VERSION@_la_CFLAGS = $(GST_ALL_CFLAGS)\
> +    $(GIO_CFLAGS) $(GST_PBUTILS_CFLAGS) -I$(top_srcdir)/fault_injection
> 
> I do not understand why you link Validate against that lib here?

As discussed on IRC, this is needed to implement the action. Furthermore, one
can't register validate actions in a GstPlugin, as at the first inspection
without the validate library being loaded the plugin will get blacklisted. We
should rework this when we have a happy conclusion with
https://bugzilla.gnome.org/show_bug.cgi?id=741260 in my opinion.

Resubmitted the patch with the ".libs" correction.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.