[Bug 743948] vc1parser: re-enable BDU parsing for bitstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743948
  GStreamer | gst-plugins-bad | git master

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> 2015-02-04 11:14:11 UTC ---
(In reply to comment #2)
> Review of attachment 296054 [details]:
> 
> Moreover, it seems that the code to detect BDU stream format is not enough as
> startcode can be present in sequence-layer-bdu-* stream formats, and also iirc
> in ASF format.
> So I think enable this code as if will broke other formats detection if done
> first.
> 
> ::: gst/videoparsers/gstvc1parse.c
> @@ +645,3 @@
>        GST_DEBUG_OBJECT (vc1parse, "Found BDU startcode");
> +      vc1parse->input_stream_format = vc1parse->output_stream_format =
> +          VC1_STREAM_FORMAT_BDU_FRAME;
> 
> I think output_stream_format will be set at negotitation time, so we should not
> set it here.

It is set in the negotiation time, but if there's nothing in the caps,
output_stream_format keeps its original value of VC1_STREAM_FORMAT_BDU, and the
parsing stops because the element assume a wrong conversion.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.