[Bug 743900] oggdemux gets first packet timestamp wrong - theora

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743900
  GStreamer | gst-plugins-base | unspecified

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296144|none                        |needs-work
             status|                            |

--- Comment #2 from Jan Schmidt <thaytan at noraisin.net> 2015-02-05 04:34:32 UTC ---
Review of attachment 296144:
 --> (https://bugzilla.gnome.org/review?bug=743900&attachment=296144)

Thanks for the patch! This fixes the timestamping for my test file, but seems
to break vorbis timestamping by modifying the duration on the first outgoing
packet.

Before:
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (30 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000440 discont header ) 0x7fedcc007220
New clock: GstSystemClock
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (165 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000400 header ) 0x7fedcc007110
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (3714 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000400 header ) 0x7fedcc007000
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1 bytes, dts: none, pts: 0:00:00.000000000, duration:
0:00:00.000000000, offset: 0, offset_end: 0, flags: 00000000 ) 0x7fedcc007110
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1 bytes, dts: none, pts: 0:00:00.000000000, duration:
0:00:00.002902494, offset: 2902494, offset_end: 128, flags: 00000000 )
0x7fedcc007220

After:
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (30 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000440 discont header ) 0x7f931c007220
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (165 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000400 header ) 0x7f931c007110
New clock: GstSystemClock
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (3714 bytes, dts: none, pts: none, duration: none, offset: 0,
offset_end: -1, flags: 00000400 header ) 0x7f931c007000
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1 bytes, dts: none, pts: 0:00:00.000000000, duration:
0:00:00.013061224, offset: 13061224, offset_end: 576, flags: 00000000 )
0x7f931c007110
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1 bytes, dts: none, pts: 0:00:00.013061224, duration:
0:00:00.002902494, offset: 15963718, offset_end: 704, flags: 00000000 )
0x7f931c007220

This causes the decoded vorbis to start 13ms late:

/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1024 bytes, dts: none, pts: 0:00:00.013061224, duration:
0:00:00.002902494, offset: -1, offset_end: -1, flags: 00000040 discont )
0x7f751c0252f0
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = chain   *******
(fakesink0:sink) (1024 bytes, dts: none, pts: 0:00:00.015963718, duration:
0:00:00.002902494, offset: -1, offset_end: -1, flags: 00000000 ) 0x7f752001c6d0

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.