[Bug 735666] design doc : trick mode handling in demuxers (SKIP)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735666
  GStreamer | gstreamer (core) | unspecified

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-02-05 09:05:02 UTC ---
(In reply to comment #31)
> Created an attachment (id=296176)
 View: https://bugzilla.gnome.org/attachment.cgi?id=296176
 Review: https://bugzilla.gnome.org/review?bug=735666&attachment=296176

> audiobasesink: Re-work GAP buffer and trick-mode handling
> 
> In trickmode no-audio mode, or when receiving a GAP buffer,
> discard the contents and render as a GAP event instead.
> 
> Make sure when rendering a gap event that the ring buffer will
> restart on PAUSED->PLAYING by setting the eos_rendering flag.
> 
> This mostly reverts commit 8557ee and replaces it. The problem
> with the previous approach is that it hangs in wait_preroll()
> on a PLAYING-PAUSED transition because it doesn't commit state
> properly.

It feels like this change is related to bug #736655. Which is having problems
with GAP events and pre-rolling of the audio sink (and maybe base sink in
general?), also not prerolling again after PLAYING->PAUSED->PLAYING transitions
when the last thing was a GAP event. Can you check?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.