[Bug 743346] When system time is increased the ongoing RTSP sessions will time out.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743346
  GStreamer | gst-rtsp-server | git master

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296199|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-02-05 19:53:14 UTC ---
Review of attachment 296199:
 --> (https://bugzilla.gnome.org/review?bug=743346&attachment=296199)

Generally looks good, thanks for updating the patch :)

::: gst/rtsp-server/rtsp-session.c
@@ +665,3 @@
  */
 gint
+gst_rtsp_session_next_timeout_usec (GstRTSPSession * session, gint64 * now)

This should probably be a plain gint64 and not a gint64*

@@ +741,3 @@
+ */
+gboolean
+gst_rtsp_session_is_expired_usec (GstRTSPSession * session, gint64 * now)

This probably shouldn't be a gint64* but a plain gint64

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.