[Bug 744096] compositor, videoaggregator: ignores input timestamps if input buffers have no duration

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Feb 8 07:55:41 PST 2015

  GStreamer | gst-plugins-bad | git master

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
 Attachment #296379|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-02-08 15:55:34 UTC ---
Review of attachment 296379:
 --> (https://bugzilla.gnome.org/review?bug=744096&attachment=296379)

I think independent of this, videoaggregator should also not do any
calculations with the framerate at all. It's never going to give useful

Also we probably need different behaviour for live than for non-live pipelines
(if input durations are -1). In live pipelines you want to take the newest
buffer that is available and does not start after the end time of the output
buffer, even if you didn't receive any newer buffers to be able to calculate
the duration of the previous buffer. In non-live pipelines you always want to
wait until the next buffer so you know the duration of the previous one and
know which of the two to place into the current output buffer.

::: gst-libs/gst/video/gstvideoaggregator.c
@@ +1002,2 @@
       if (end_time == -1) {
+        if (start_time > output_end_time) {

output_end_time is in rnning time, start_time a buffer timestamp. That seems
not ideal to compare :)

@@ +1006,3 @@
+          gst_buffer_unref (buf);
+          continue;
+        } else if (start_time < output_start_time) {

Same here

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list